[gatkins]

Hi guys,

It seems that inactive/old discount codes can be inputted on the cart page without any expired/inactive message being displayed to the user. The reason this is a big problem is that customers can proceed with the order thinking the coupon was successfully accepted, even though it could have expired.


In my case I have setup a discount with a coupon code. The discount has since expired - but my cart page still happily accepts the coupon code (but doesn't apply the discount). Surely it should in fact display a message box saying the discount code is no loner active, or some such message. Note that I have also tried simply making the discount inactive and also reduced the number of usages down to zero, but the same behavior still occurs.

[gatkins]

I should have clarified: I am using the discount to give away a free item (which isn't a product in the store). So from that point of view the customer won't necessary notice that the coupon wasn't accepted without an explicit message. I would think that an explicit message would be the behaviour anyway - the same as when you enter a coupon code that doesn't, or has never, existed at all which shows up a popup error message.

[Aleksey]

Hi!

I added it to the roadmap.

Thanks!

[Aleksey]

Hi!

We just published an update of the Discount Engine, which adds the coupon applicability check.

Thank you

[kgarrett]

Likewise, could there be a message that says the coupon has been applied, or is that overkill? Also, when I apply my coupons, I have one set right now to take $5 off the subtotal of all the items: http://ekceterahosti...nd/store/cart/. The code is: trfschool.

It's applying the code, but it applies it to the first line item in the cart. I'd like to have something come under subtotal that shows a discount there, rather than taking it off the first line item. Can you tell me how to go about doing that?

Thanks.

[apepp]

Hi K!

You can add an onSuccess function to the button:

<p>
<a href="javascript:;" title="Apply coupon code" onclick="return $(this).getForm().sendRequest(
'on_action',
{
onSuccess: function(){
custom_alert('Coupon Applied');
},
onAfterUpdate: init_effects,
update: {'cart_page_div': 'cart_partial', 'mini_cart_id': 'shop_mini_cart'}
});">
<img title="Apply coupon code" alt="Apply coupon code" src="<?= theme_resource_url('images/shipping-estimate.png') ?>"></a>
</p>

...you could also render a total discount value only if applicable:

<? if ($discount): ?>
<h1>Total Discount</h1>
<p> - <?= format_currency($discount) ?></p>
<? endif ?>

...the discount column is generally needed for "per item" discounts, they might be different values per item. So i think the discount column works this way regardless of whether it really is just meant to be for the sub-total or not.

...don't know another way around for that unfortunatley, it might well have to do with the discount engine way of doing things to cover many variables.

...other than hiding the column, but then you might need it for other variable discounts down the road.

[Manca]

Discounts in LS are always applied on the cart items. When you specify a discount to be applied to the cart subtotal, LS takes the discount amount and distributes it to cart items. This is partly due to the tax engine. It's mentioned in the documentation.
You could edit your cart to only display the total discount (as Andrew suggested) and hide the discounted prices of the individual items (just display the full product price), but then you wouldn't be able to show the individual products' discounted prices.

Thank you

[kgarrett]

The "Coupon Applied" alert doesn't appear to work. I entered it just like Andrew displayed. Any thoughts?

I'm on a new server now: http://craftnightout.com/store/cart/

[apepp]

Hi K,

There is a javascript error on the page specifically "jcarousel" plugin...we will need to debug the javascript errors, can you disable the jcarousel plugin and test?

...there maybe others, so it will be a process of elimination.

...i recommend using firebug plugin in firefox or the devloper tools in chrome/safari to debug what javascripts are causing problems...

...you might have to go through your scripts to determine which are needed and which ones aren't, so we need to keep those clean.

...it looks like you may have jquery scripts running that aren't being used across the site...or they are conflicting with other scripts.